RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v29]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Jun 26 03:09:29 UTC 2025


> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is shown without radiobutton in WIndowsLookAndFeel as there was no provision of drawing the radiobutton alongside icon.
> If icon is not there, the radiobutton is drawn. Added provision of drawing the radiobutton windows Skin even when imageIcon is present.

Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 33 additional commits since the last revision:

 - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
 - Windows 10 offset correction without icon
 - Fix issue for presence of gap between buller and text only if atleast 1 menuitem has imageicon
 - Text alignment fix
 - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
 - Review comments fix
 - Expand wildcard imports
 - Remove unneeded methods
 - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
 - Code duplication removed
 - ... and 23 more: https://git.openjdk.org/jdk/compare/5ac58a9a...ea1016fc

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/23324/files
  - new: https://git.openjdk.org/jdk/pull/23324/files/f019f638..ea1016fc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=23324&range=28
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23324&range=27-28

  Stats: 103274 lines in 1910 files changed: 61970 ins; 26723 del; 14581 mod
  Patch: https://git.openjdk.org/jdk/pull/23324.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23324/head:pull/23324

PR: https://git.openjdk.org/jdk/pull/23324


More information about the client-libs-dev mailing list