RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v29]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Jun 26 04:36:38 UTC 2025


On Thu, 26 Jun 2025 03:09:29 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is shown without radiobutton in WIndowsLookAndFeel as there was no provision of drawing the radiobutton alongside icon.
>> If icon is not there, the radiobutton is drawn. Added provision of drawing the radiobutton windows Skin even when imageIcon is present.
>
> Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 33 additional commits since the last revision:
> 
>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
>  - Windows 10 offset correction without icon
>  - Fix issue for presence of gap between buller and text only if atleast 1 menuitem has imageicon
>  - Text alignment fix
>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
>  - Review comments fix
>  - Expand wildcard imports
>  - Remove unneeded methods
>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
>  - Code duplication removed
>  - ... and 23 more: https://git.openjdk.org/jdk/compare/0f385feb...ea1016fc

> 4. If I add another regular menu item with an icon, the icon is rendered below the menu item text.

I couldn't reproduce this

![image](https://github.com/user-attachments/assets/1a4b93be-2d8c-4710-b094-4b7a5691d1cf)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-3007017870


More information about the client-libs-dev mailing list