RFR: 8349188: LineBorder does not scale correctly [v3]

Sergey Bylokhov serb at openjdk.org
Sat Jun 28 04:30:39 UTC 2025


On Fri, 27 Jun 2025 19:46:56 GMT, Rajat Mahajan <rmahajan at openjdk.org> wrote:

>> Modified the code to account for border thickness correctly and updated the related tests to make sure we are testing the new change.
>> 
>> Testing done.
>
> Rajat Mahajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix blank line

src/java.desktop/share/classes/javax/swing/border/LineBorder.java line 166:

> 164:             Shape inner;
> 165: 
> 166:             int offs = clipRound(this.thickness * scaleFactor);

Please double-check whether you need to use `Region.clipScale()` instead.

I actually do not remember when to use one over the other. Maybe if you find a review request for the patch where these methods were added, you can confirm which one should be used. I checked the current source, and it seems that we randomly use one or the other, which seems incorrect.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26025#discussion_r2173117608


More information about the client-libs-dev mailing list