RFR: 8349188: LineBorder does not scale correctly [v3]

Sergey Bylokhov serb at openjdk.org
Sat Jun 28 04:30:39 UTC 2025


On Sat, 28 Jun 2025 04:26:31 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Rajat Mahajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix blank line
>
> src/java.desktop/share/classes/javax/swing/border/LineBorder.java line 166:
> 
>> 164:             Shape inner;
>> 165: 
>> 166:             int offs = clipRound(this.thickness * scaleFactor);
> 
> Please double-check whether you need to use `Region.clipScale()` instead.
> 
> I actually do not remember when to use one over the other. Maybe if you find a review request for the patch where these methods were added, you can confirm which one should be used. I checked the current source, and it seems that we randomly use one or the other, which seems incorrect.

it might be possible we should use one for the left/top part and another for the right/bottom so we will not create a gaps.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26025#discussion_r2173118068


More information about the client-libs-dev mailing list