RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v2]

[Alexey Ivanov]

On Tue, 20 May 2025 17:01:26 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments fixed : Rearranged and reused code by creating a new Helper MenuItemTestHelper.java
>
> test/jdk/javax/swing/JMenuItem/MenuItemTest/MenuItemTestHelper.java line 43:
> 
>> 41: import javax.swing.UIManager;
>> 42: 
>> 43: class MenuItemTestHelper {
> 
> I would've kept `MenuItemTest` as the name of the class. It's fine either way.
> 
> I'd also mark this class as `final`. It may be `public` or be left with the default access.

However, `-Helper` could be better — the name of the class clearly indicates that this class is not _a test_ but a helper class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25319#discussion_r2098697447