RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v2]

Manukumar V S mvs at openjdk.org
Wed May 21 17:23:18 UTC 2025


On Tue, 20 May 2025 19:18:06 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/javax/swing/JMenuItem/MenuItemTest/MenuItemTestHelper.java line 43:
>> 
>>> 41: import javax.swing.UIManager;
>>> 42: 
>>> 43: class MenuItemTestHelper {
>> 
>> I would've kept `MenuItemTest` as the name of the class. It's fine either way.
>> 
>> I'd also mark this class as `final`. It may be `public` or be left with the default access.
>
> However, `-Helper` could be better — the name of the class clearly indicates that this class is not _a test_ but a helper class.

Added final modifier

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25319#discussion_r2100806967


More information about the client-libs-dev mailing list