RFR: 8139228: JFileChooser renders file names as HTML document [v3]

Alexey Ivanov aivanov at openjdk.org
Wed May 21 12:09:02 UTC 2025


On Tue, 20 May 2025 18:48:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> test/jdk/javax/swing/JFileChooser/HTMLFileName.java line 51:
> 
>> 49:                          ComboBox remains in plain text, then test PASS.
>> 50:                          If it appears to be in HTML format with Pink color,
>> 51:                          then test FAILS.
> 
> Suggestion:
> 
>                          ComboBox remains in plain text, then test passes.
>                          If it appears to be in HTML format with Pink color,
>                          then test fails.
> 
> You could be more specific: _“click **Fail**”_ if a condition isn't met. (Otherwise, continue with the test.) End the instructions with _“click **Pass**”_.
> 
> Anyway, the instructions are pretty clear as they are, so real change is required.

You may want to switch to HTML-formatted instructions to alleviate differences in the default fonts in different L&Fs.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24439#discussion_r2100119989


More information about the client-libs-dev mailing list