RFR: 8139228: JFileChooser renders file names as HTML document [v3]

Tejesh R tr at openjdk.org
Wed May 21 16:00:13 UTC 2025


On Wed, 21 May 2025 12:06:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/javax/swing/JFileChooser/HTMLFileName.java line 51:
>> 
>>> 49:                          ComboBox remains in plain text, then test PASS.
>>> 50:                          If it appears to be in HTML format with Pink color,
>>> 51:                          then test FAILS.
>> 
>> Suggestion:
>> 
>>                          ComboBox remains in plain text, then test passes.
>>                          If it appears to be in HTML format with Pink color,
>>                          then test fails.
>> 
>> You could be more specific: _“click **Fail**”_ if a condition isn't met. (Otherwise, continue with the test.) End the instructions with _“click **Pass**”_.
>> 
>> Anyway, the instructions are pretty clear as they are, so real change is required.
>
> You may want to switch to HTML-formatted instructions to alleviate differences in the default fonts in different L&Fs.

Why would we need HTML-formatted instructions btw ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24439#discussion_r2100649064


More information about the client-libs-dev mailing list