RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v6]

[Alexey Ivanov]

On Wed, 21 May 2025 17:23:17 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> There are some compilation failures noticed in the recently open sourced test javax/swing/JMenuItem/bug6197830.java. The compilation failures are due to missing import statements and a missing dependency file MenuItemTest.java.
>> 
>> Fix: I have added the required import statements and added the code-piece from MenuItemTest.java as a method getMenuItemTestFrame().
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added final modifier to the class MenuItemTestHelper

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JMenuItem/MenuItemTest/MenuItemTestHelper.java line 52:

> 50:             }
> 51:         }
> 52:         Icon myIcon = new ColoredIcon(Color.RED, 10, 10);

The blank here was in its own place. It separated the code that sets L&F from creating icons.

I think there should be a blank line after the icons are created, too.

-------------

PR Review: https://git.openjdk.org/jdk/pull/25319#pullrequestreview-2860741769
PR Review Comment: https://git.openjdk.org/jdk/pull/25319#discussion_r2102249558