RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v6]
Manukumar V S
mvs at openjdk.org
Thu May 22 13:07:15 UTC 2025
On Thu, 22 May 2025 10:44:48 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Added final modifier to the class MenuItemTestHelper
>
> test/jdk/javax/swing/JMenuItem/MenuItemTest/MenuItemTestHelper.java line 52:
>
>> 50: }
>> 51: }
>> 52: Icon myIcon = new ColoredIcon(Color.RED, 10, 10);
>
> The blank here was in its own place. It separated the code that sets L&F from creating icons.
>
> I think there should be a blank line after the icons are created, too.
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25319#discussion_r2102510295
More information about the client-libs-dev
mailing list