RFR: 8357598: Toolkit.removeAWTEventListener should handle null listener in AWTEventListenerProxy [v2]

[Tejesh R]

On Tue, 27 May 2025 17:38:32 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> The issue was found here: https://github.com/openjdk/jdk/pull/24692#discussion_r2089545502
>> 
>> AWTEventListener and AWTEventListenerProxy are public classes and there's no assertion that EventListenerProxy.getListener() will always return a non-null value. So removeAWTEventListener method should fetch the listener from the proxy and check it for null similar to how it is implemented in addAWTEventListener. Currently, it works fine because we never insert null values into the map. So it is just a code clarification.
>> 
>> One of the test is updated just to touch that codepath.
>
> Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update test/jdk/java/awt/Toolkit/AWTEventListenerProxyTest/AWTEventListenerProxyTest.java
>   
>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

test/jdk/java/awt/Toolkit/AWTEventListenerProxyTest/AWTEventListenerProxyTest.java line 24:

> 22:  */
> 23: 
> 24: /*

Suggestion:

/*
 * @test
 * @bug 4290704 8357598
 * @summary Test use of AWTEventListenerProxyTest class
 */


Most of the test follow this pattern for jtreg tags. It would be good if you use it too for code consistency.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25401#discussion_r2115549915