RFR: 8357598: Toolkit.removeAWTEventListener should handle null listener in AWTEventListenerProxy [v2]

[Alexey Ivanov]

On Fri, 30 May 2025 09:52:21 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/jdk/java/awt/Toolkit/AWTEventListenerProxyTest/AWTEventListenerProxyTest.java
>>   
>>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>
> test/jdk/java/awt/Toolkit/AWTEventListenerProxyTest/AWTEventListenerProxyTest.java line 24:
> 
>> 22:  */
>> 23: 
>> 24: /*
> 
> Suggestion:
> 
> /*
>  * @test
>  * @bug 4290704 8357598
>  * @summary Test use of AWTEventListenerProxyTest class
>  */
> 
> 
> Most of the test follow this pattern for jtreg tags. It would be good if you use it too for code consistency.

Not required, but can be updated…

> test/jdk/java/awt/Toolkit/AWTEventListenerProxyTest/AWTEventListenerProxyTest.java line 169:
> 
>> 167:         AWTEventListener[] array = tk.getAWTEventListeners();
>> 168:         if (array == null || array.length != expected) {
>> 169:             System.out.println("[Simple test failed!!]");
> 
> I don't think this print statement is required?

Probably not, but it follows the common pattern in the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25401#discussion_r2115659639
PR Review Comment: https://git.openjdk.org/jdk/pull/25401#discussion_r2115660853