RFR: 8371508: [macos] In Aqua LaF menu items layout is incorrect in RTL orientation [v2]

Alexander Zuev kizune at openjdk.org
Thu Nov 13 20:11:02 UTC 2025


On Wed, 12 Nov 2025 04:49:37 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use correct bug id in the test.
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaMenuPainter.java line 538:
> 
>> 536:             checkIconR.x = w - (checkIconR.x + checkIconR.width);
>> 537:             if (menuItem.getHorizontalTextPosition() != SwingConstants.CENTER) {
>> 538:                 int d = textR.x - iconR.x;
> 
> `d` refers to difference ? Could be `diff` for readability ?

D is for distance but i can rename it into delta - that will cover both meanings.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28210#discussion_r2524793108


More information about the client-libs-dev mailing list