RFR: 8371508: [macos] In Aqua LaF menu items layout is incorrect in RTL orientation [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Wed Nov 12 10:05:06 UTC 2025
On Sat, 8 Nov 2025 23:26:19 GMT, Alexander Zuev <kizune at openjdk.org> wrote:
>> The problem is that we do not correct the icon and text re-alignment that happens when we call SwingUtilities.layoutCompoundLabel
>>
>> Here's the comparison of the alignment before and after the fix
>> Before:
>> <img width="708" height="788" alt="before_fix" src="https://github.com/user-attachments/assets/9bcd3fb1-5186-45ea-98d9-d2bc534ca51e" />
>> After:
>> <img width="708" height="788" alt="after_fix" src="https://github.com/user-attachments/assets/ec6dfdf5-a515-4ef6-b70d-cc4019e00826" />
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>
> Use correct bug id in the test.
It seems the check icon is almost overlapping with text.....maybe a little more gap is needed...
<img width="384" height="209" alt="image" src="https://github.com/user-attachments/assets/0c8b5d09-3594-4d26-a27a-4952669453e2" />
unlike what we have in native
<img width="177" height="233" alt="image" src="https://github.com/user-attachments/assets/4e4ae48d-b470-4f42-8d95-fd2ac7fed2b8" />
Also, there is a closed test ManualBug6458123.java where the alignment seems to be wrong
<img width="782" height="201" alt="image" src="https://github.com/user-attachments/assets/609e39c8-4901-4b85-bba4-994c8fb9ecb5" />
whereas it should have been
<img width="798" height="212" alt="image" src="https://github.com/user-attachments/assets/dc9ff910-30c2-44c5-b495-c7c5aee025d8" />
Probably CENTER check you added should be extended..
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28210#issuecomment-3521095162
More information about the client-libs-dev
mailing list