RFR: 8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data [v2]

Harshitha Onkar honkar at openjdk.org
Fri Oct 17 00:08:05 UTC 2025


On Tue, 7 Oct 2025 18:01:28 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Added a small test to check the size of ICC profile data after serialization.
>> For standard profiles, the size should stay small (under 200 bytes) because the real data is not stored.
>> For custom profiles, the size depends on the real data plus a small overhead.
>
> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into JDK-8369032
>  - Update SerializedFormSize.java
>  - 8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data

LGTM

test/jdk/java/awt/color/ICC_Profile/SerializedFormSize.java line 50:

> 48:             int dataSize = data.length;
> 49:             int min = 3; // At least version, name and data fields
> 50:             int max = 200; // Small enough to confirm no data saved

max = 200, does it account for header data (128 bytes) and some padding ?

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27616#pullrequestreview-3347462406
PR Review Comment: https://git.openjdk.org/jdk/pull/27616#discussion_r2437825938


More information about the client-libs-dev mailing list