RFR: 8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data [v2]

Sergey Bylokhov serb at openjdk.org
Fri Oct 17 00:47:10 UTC 2025


On Fri, 17 Oct 2025 00:02:15 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8369032
>>  - Update SerializedFormSize.java
>>  - 8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data
>
> test/jdk/java/awt/color/ICC_Profile/SerializedFormSize.java line 50:
> 
>> 48:             int dataSize = data.length;
>> 49:             int min = 3; // At least version, name and data fields
>> 50:             int max = 200; // Small enough to confirm no data saved
> 
> max = 200, does it account for header data (128 bytes) and some padding ?

200 does not include the actual profile data / the header, only a few strings and references.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27616#discussion_r2437924449


More information about the client-libs-dev mailing list