RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v37]

Khalid Boulanouare duke at openjdk.org
Thu Sep 4 15:53:49 UTC 2025


On Thu, 4 Sep 2025 14:22:01 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Khalid Boulanouare has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Organizes imports
>
> test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line 115:
> 
>> 113: 
>> 114:         if (testResize) {
>> 115:             wasLWClicked = false;
> 
> May I also suggest reversing the condition:
> 
> 
>        if (!testResize) {
>           return true;
>        }
> 
> 
> This brings the shorter `else` section higher, and it's the end of the test if `testResize` is `false`.
> 
> The testing for resize then is written with reduced indentation.

Looks better this way, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2322640069


More information about the client-libs-dev mailing list