RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v37]
Khalid Boulanouare
duke at openjdk.org
Thu Sep 4 15:56:47 UTC 2025
On Thu, 4 Sep 2025 14:26:52 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Khalid Boulanouare has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Organizes imports
>
> test/jdk/java/awt/Mixing/AWT_Mixing/MixingPanelsResizing.java line 315:
>
>> 313: mainThread.interrupt();
>> 314: }//fail()
>> 315: static class TestPassedException extends RuntimeException {
>
> Suggestion:
>
> }//fail()
>
> static class TestPassedException extends RuntimeException {
Done.
> test/jdk/java/awt/Mixing/AWT_Mixing/MixingPanelsResizing.java line 318:
>
>> 316: }
>> 317: }// class JButtonInGlassPane
>> 318:
>
> Just one blank line is enough.
>
> That is you should see only one blank line in your editor in the end of the file (some editors, like `vim`, hide this very last line).
Done.
> test/jdk/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java line 692:
>
>> 690: }//fail()
>> 691: static class TestPassedException extends RuntimeException {
>> 692: }
>
> Suggestion:
>
> }//fail()
>
> static class TestPassedException extends RuntimeException {
> }
>
> Add blank lines between class members, it improves readability, the code is easier to scan quickly with eyes.
Done.
> test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 76:
>
>> 74: return true;
>> 75: }
>> 76: public SimpleOverlappingTestBase() {
>
> Suggestion:
>
> }
>
> public SimpleOverlappingTestBase() {
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2322648034
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2322648676
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2322649336
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2322649974
More information about the client-libs-dev
mailing list