RFR: 8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java [v3]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Sep 5 09:32:16 UTC 2025


On Fri, 5 Sep 2025 09:21:58 GMT, Srinivas Mandalika <smandalika at openjdk.org> wrote:

>> test/jdk/java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java line 151:
>> 
>>> 149:         robot.setAutoDelay(150);
>>> 150:         robot.setAutoWaitForIdle(true);
>>> 151:         if (!windowFocusGainedLatch.await(1500, TimeUnit.MILLISECONDS)) {
>> 
>> Once there is a timeout, we know the frame did not gain focus. Can we throw exception and stop execution ?
>
> Yes, that was the code initially. The previous review suggested removal of the code as being redundant in the presence of the main method's throws Exception. There are pros and con to argue on both ways. Please let me know if you strong reason to not ok to not have in the current form.

No, the code I asked to remove was for catching InterruptedException and rethrowing..This is for throwing RTE upfront if timeout exceeded, not by setting `passed `to `false `and continuing..I guess it has its merit of not continuing..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26471#discussion_r2324586626


More information about the client-libs-dev mailing list