RFR: 8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java [v3]
Srinivas Mandalika
smandalika at openjdk.org
Mon Sep 8 08:42:35 UTC 2025
On Fri, 5 Sep 2025 09:29:32 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Yes, that was the code initially. The previous review suggested removal of the code as being redundant in the presence of the main method's throws Exception. There are pros and con to argue on both ways. Please let me know if you strong reason to not ok to not have in the current form.
>
> No, the code I asked to remove was for catching InterruptedException and rethrowing..This is for throwing RTE upfront if timeout exceeded, not by setting `passed `to `false `and continuing..I guess it has its merit of not continuing..
I have made the changes accordingly.
Removed the passed & eventType variable for test pass/fail assertion.
Tweaked to assert test scenario only on based on latch.
Removed boiler plate code for mouse Move & Click.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26471#discussion_r2329547280
More information about the client-libs-dev
mailing list