RFR: 8365379: SU3.applyInsets may produce wrong results [v11]
Sergey Bylokhov
serb at openjdk.org
Tue Sep 16 08:09:08 UTC 2025
On Tue, 16 Sep 2025 06:51:14 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:
>> Hi Reviewers,
>>
>> I have updated the insets calculation, similar calculation observed in **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified code
>>
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>
> Removed null check and fixed alignment
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java line 556:
> 554:
> 555: static void applyInsets(Rectangle rect, Insets insets, boolean leftToRight) {
> 556: if (insets != null) {
This method is used only once. Can we remove it and call SwingUtilities3.applyInsets directly instead?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27157#discussion_r2351355246
More information about the client-libs-dev
mailing list