RFR: 8365379: SU3.applyInsets may produce wrong results [v11]

Alexey Ivanov aivanov at openjdk.org
Tue Sep 16 10:22:50 UTC 2025


On Tue, 16 Sep 2025 08:06:16 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed null check and fixed alignment
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java line 556:
> 
>> 554: 
>> 555:     static void applyInsets(Rectangle rect, Insets insets, boolean leftToRight) {
>> 556:         if (insets != null) {
> 
> This method is used only once. Can we remove it and call SwingUtilities3.applyInsets directly instead?

Yep! I was about to write the same suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27157#discussion_r2351843766


More information about the client-libs-dev mailing list