RFR: 8365379: SU3.applyInsets may produce wrong results [v12]
Renjith Kannath Pariyangad
rkannathpari at openjdk.org
Tue Sep 16 13:27:58 UTC 2025
On Tue, 16 Sep 2025 10:19:06 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java line 556:
>>
>>> 554:
>>> 555: static void applyInsets(Rectangle rect, Insets insets, boolean leftToRight) {
>>> 556: if (insets != null) {
>>
>> This method is used only once. Can we remove it and call SwingUtilities3.applyInsets directly instead?
>
> Yep! I was about to write the same suggestion.
Observed **BasicMenuItemUI.java** have similar call, that also updated
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27157#discussion_r2352496019
More information about the client-libs-dev
mailing list