RFR: 8367376: Bad ButtonUI prevents other components from updating when system changes desktop properties [v5]

Jeremy Wood jwood at openjdk.org
Mon Sep 22 16:55:50 UTC 2025


> Previously:
> 
> If DesktopProperty#updateAllUIs threw an exception, we would never reset the update-pending property to false. This means any subsequent call to `updateUI()` would not attempt to call `updateAllUIs()`
> 
> With this change:
> Subsequent calls to DesktopProperty#updateUI() can still trigger at least one call to updateAllUIs().

Jeremy Wood has updated the pull request incrementally with three additional commits since the last revision:

 - 8367376: use same try/finally pattern for SynthL&F
   
   This is in response to:
   https://github.com/openjdk/jdk/pull/27205#discussion_r2357719216
 - 8367376: use same try/finally pattern for MetalL&F
   
   This is in response to:
   https://github.com/openjdk/jdk/pull/27205#discussion_r2357716063
 - 8367376: remove setLookAndFeel
   
   This was probably left over from an earlier draft; this test uses the TestDesktopProperty class so it doesn't rely on/test any particular L&F.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/27205/files
  - new: https://git.openjdk.org/jdk/pull/27205/files/108e2d5a..8f056060

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=27205&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=27205&range=03-04

  Stats: 26 lines in 3 files changed: 6 ins; 14 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/27205.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/27205/head:pull/27205

PR: https://git.openjdk.org/jdk/pull/27205


More information about the client-libs-dev mailing list