RFR: 8367376: Bad ButtonUI prevents other components from updating when system changes desktop properties [v6]

Jeremy Wood jwood at openjdk.org
Sat Sep 27 04:40:03 UTC 2025


> Previously:
> 
> If DesktopProperty#updateAllUIs threw an exception, we would never reset the update-pending property to false. This means any subsequent call to `updateUI()` would not attempt to call `updateAllUIs()`
> 
> With this change:
> Subsequent calls to DesktopProperty#updateUI() can still trigger at least one call to updateAllUIs().

Jeremy Wood has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:

 - 8367376: test all installed L&F's
   
   This is in response to:
   https://git.openjdk.org/jdk/pull/27205#discussion_r2382574446
 - Merge branch 'master' into JDK-8367376
 - 8367376: use same try/finally pattern for SynthL&F
   
   This is in response to:
   https://github.com/openjdk/jdk/pull/27205#discussion_r2357719216
 - 8367376: use same try/finally pattern for MetalL&F
   
   This is in response to:
   https://github.com/openjdk/jdk/pull/27205#discussion_r2357716063
 - 8367376: remove setLookAndFeel
   
   This was probably left over from an earlier draft; this test uses the TestDesktopProperty class so it doesn't rely on/test any particular L&F.
 - 8367376: rename test file
   
   This is in response to:
   https://github.com/openjdk/jdk/pull/27205#discussion_r2356674752
 - 8367376: add new line to end of file
   
   This is in response to:
   https://github.com/openjdk/jdk/pull/27205#discussion_r2356666306
 - 8367376: changing field names
   
   This is in response to:
   https://github.com/openjdk/jdk/pull/27205#discussion_r2356664929
 - Update test/jdk/com/sun/java/swing/plaf/Test8367376.java
   
   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
 - Update test/jdk/com/sun/java/swing/plaf/Test8367376.java
   
   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
 - ... and 2 more: https://git.openjdk.org/jdk/compare/e493cf49...1b669f8d

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/27205/files
  - new: https://git.openjdk.org/jdk/pull/27205/files/8f056060..1b669f8d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=27205&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=27205&range=04-05

  Stats: 241890 lines in 3698 files changed: 179517 ins; 41409 del; 20964 mod
  Patch: https://git.openjdk.org/jdk/pull/27205.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/27205/head:pull/27205

PR: https://git.openjdk.org/jdk/pull/27205


More information about the client-libs-dev mailing list