RFR: 8370945: With Windows LAF, the location of a JMenuItem icon is incorrect [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Thu Feb 19 03:27:03 UTC 2026
> [JDK-8348760](https://bugs.openjdk.org/browse/JDK-8348760) fixed an issue in Windows L&F JMenuItem layout whereby radio bullet/checkmark was rendered in different columnspace than menuitem imageicon so radiobullet/checkmark is rendered in first column and imageicon is rendered in 2nd column but this rendering of imageicon in 2nd columnspace was done invariably for all JMenuItem irrespective of if it is JRadioButtonMenuItem or JCheckBoxMenuItem or JMenuItem, which is wrong.
>
> Normal JMenuItem (which are not JRadioButtonMenuItem or JCheckBoxMenuItem) imageicon rendering should be done in first columnspace as was done before JDK-8348760 fix because there is no radiobullet/checkmark to render for those menuitems so no need to reserve columnspace for those bullet/checkmark icon
>
> Before fix
>
> <img width="205" height="127" alt="image" src="https://github.com/user-attachments/assets/13a1e352-5e8d-4251-b7a7-032935eab74e" />
>
>
> After fix
>
> <img width="195" height="131" alt="image" src="https://github.com/user-attachments/assets/84ec3ee6-2823-4bf7-840d-b53f2e9d44c3" />
Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
Text alignment
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/29730/files
- new: https://git.openjdk.org/jdk/pull/29730/files/fd677cb9..910b1db0
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=29730&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=29730&range=00-01
Stats: 138 lines in 3 files changed: 6 ins; 126 del; 6 mod
Patch: https://git.openjdk.org/jdk/pull/29730.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/29730/head:pull/29730
PR: https://git.openjdk.org/jdk/pull/29730
More information about the client-libs-dev
mailing list