RFR: 8370945: With Windows LAF, the location of a JMenuItem icon is incorrect
Prasanta Sadhukhan
psadhukhan at openjdk.org
Thu Feb 19 03:27:04 UTC 2026
On Mon, 16 Feb 2026 01:30:06 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> [JDK-8348760](https://bugs.openjdk.org/browse/JDK-8348760) fixed an issue in Windows L&F JMenuItem layout whereby radio bullet/checkmark was rendered in different columnspace than menuitem imageicon so radiobullet/checkmark is rendered in first column and imageicon is rendered in 2nd column but this rendering of imageicon in 2nd columnspace was done invariably for all JMenuItem irrespective of if it is JRadioButtonMenuItem or JCheckBoxMenuItem or JMenuItem, which is wrong.
>
> Normal JMenuItem (which are not JRadioButtonMenuItem or JCheckBoxMenuItem) imageicon rendering should be done in first columnspace as was done before JDK-8348760 fix because there is no radiobullet/checkmark to render for those menuitems so no need to reserve columnspace for those bullet/checkmark icon
>
> Before fix
>
> <img width="205" height="127" alt="image" src="https://github.com/user-attachments/assets/13a1e352-5e8d-4251-b7a7-032935eab74e" />
>
>
> After fix
>
> <img width="195" height="131" alt="image" src="https://github.com/user-attachments/assets/84ec3ee6-2823-4bf7-840d-b53f2e9d44c3" />
Reverted the text alignment to have vertical alignment as before, but kept the JMenuItem imageicon alignment as it seems to be at par with native app for normal non-radio/non-check JMenuItem (as mentioned here https://github.com/openjdk/jdk/pull/29730#issuecomment-3919123593) and this JBS is about that only..
<img width="415" height="387" alt="image" src="https://github.com/user-attachments/assets/4b5f11d8-cade-4f07-8cb3-cc188a994a73" />
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29730#issuecomment-3924464416
More information about the client-libs-dev
mailing list