RFR: 8378057: CAccessibility roleKey and AWTAccessor.AccessibleBundleAccessor are Redundant [v2]

Sergey Bylokhov serb at openjdk.org
Fri Feb 27 21:08:34 UTC 2026


On Tue, 24 Feb 2026 06:44:20 GMT, Jeremy Wood <jwood at openjdk.org> wrote:

>> This PR proposes replacing the native `roleKey` method with the `AWTAccessor.AccessibleBundleAccessor`. They appear to do the same thing.
>> 
>> I ran all the existing jtreg tests in the javax/accessibility folder and observed no new regressions (tested on Mac).
>
> Jeremy Wood has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8378057: changing null check
>   
>   This is in response to:
>   https://github.com/openjdk/jdk/pull/29868#discussion_r2844805891

src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessibility.java line 121:

> 119:             String roleStr = AWTAccessor.getAccessibleBundleAccessor().
> 120:                     getKey(nvRole);
> 121:             if (!ignoredRoles.contains(roleStr)) {

The change looks fine, but I’m wondering if we need the same null check here as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29868#discussion_r2866206079


More information about the client-libs-dev mailing list