RFR: 8378057: CAccessibility roleKey and AWTAccessor.AccessibleBundleAccessor are Redundant [v2]

[Jeremy Wood]

On Fri, 27 Feb 2026 21:05:29 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Jeremy Wood has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8378057: changing null check
>>   
>>   This is in response to:
>>   https://github.com/openjdk/jdk/pull/29868#discussion_r2844805891
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessibility.java line 121:
> 
>> 119:             String roleStr = AWTAccessor.getAccessibleBundleAccessor().
>> 120:                     getKey(nvRole);
>> 121:             if (!ignoredRoles.contains(roleStr)) {
> 
> The change looks fine, but I’m wondering if we need the same null check here as well.

I don't think we *need* it, but I added one just now since you asked about it.

Previously this invocation (at line 119) did not include a null check, and the other invocation (at line 1037) did.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29868#discussion_r2866345705