RFR: 8375567: Remove AppContext usage from Swing Motif L&F classes [v2]
Phil Race
prr at openjdk.org
Tue Jan 20 19:48:02 UTC 2026
On Tue, 20 Jan 2026 09:30:09 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8375567
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/motif/MotifToggleButtonUI.java line 49:
>
>> 47: public class MotifToggleButtonUI extends BasicToggleButtonUI
>> 48: {
>> 49: private static final MotifToggleButtonUI MOTIF_TOGGLE_BUTTON_UI = new MotifToggleButtonUI();
>
> Isn't it too repetitive? Motif… motif… motif…
I don't think so. The var name is the only one that could be changed and it seems fine to me to keep the name similar to the previous var.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29282#discussion_r2709829713
More information about the client-libs-dev
mailing list