RFR: 8375567: Remove AppContext usage from Swing Motif L&F classes [v2]
Sergey Bylokhov
serb at openjdk.org
Tue Jan 20 20:23:46 UTC 2026
On Tue, 20 Jan 2026 19:44:36 GMT, Phil Race <prr at openjdk.org> wrote:
>> src/java.desktop/share/classes/com/sun/java/swing/plaf/motif/MotifToggleButtonUI.java line 49:
>>
>>> 47: public class MotifToggleButtonUI extends BasicToggleButtonUI
>>> 48: {
>>> 49: private static final MotifToggleButtonUI MOTIF_TOGGLE_BUTTON_UI = new MotifToggleButtonUI();
>>
>> Isn't it too repetitive? Motif… motif… motif…
>
> I don't think so. The var name is the only one that could be changed and it seems fine to me to keep the name similar to the previous var.
The type of the var MotifToggleButtonUI can be changed to the ComponentUI, and the name can be simplified to TOGGLE_BUTTON_UI or even just UI similar to how it is named in JComponent where it is saved, or just "INSTANCE"?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29282#discussion_r2709940835
More information about the client-libs-dev
mailing list