RFR: 8375567: Remove AppContext usage from Swing Motif L&F classes [v2]
Phil Race
prr at openjdk.org
Tue Jan 20 23:00:30 UTC 2026
On Tue, 20 Jan 2026 20:20:07 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> I don't think so. The var name is the only one that could be changed and it seems fine to me to keep the name similar to the previous var.
>
> The type of the var MotifToggleButtonUI can be changed to the ComponentUI, and the name can be simplified to TOGGLE_BUTTON_UI or even just UI similar to how it is named in JComponent where it is saved, or just "INSTANCE"?
True that createUI returns a ComponentUI, but the proposed code makes it clear what is the actual type, and the removed code used MotifToggleButtonUI too, even thought it could have used ComponentUI
No extra cost to this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29282#discussion_r2710365398
More information about the client-libs-dev
mailing list