Webrev: "arithmetic syntax error" when working with non-commited changes

[Stanislav Baiduzhyi]

On Tuesday 12 May 2015 17:06:37 Jonathan Gibbons wrote:
> There has been some churn recently with respect to the variable
> HG_LIST_FROM_COMMIT.
> 
> See
> http://hg.openjdk.java.net/code-tools/webrev/rev/935f1eaa4691
> http://hg.openjdk.java.net/code-tools/webrev/rev/09eb35524f9a
> 
> Therefore, I would suggest whether this needs to be re-investigated in
> the light of those recent changes.  In particular, the tip has changed
> since this thread started.

Issue still exists in current tip. I've updated the webrev, link is the same:
https://e5decb045a719fb58df46fd7e03c2f98cddc1ac6.googledrive.com/host/0B5Kp-cB1sXJrfk9NQTVHMTJTdWpYX3dWaExreWN0V0hQZ3d0eGIyZDltdHBCbmhYcXpzRFk/fix-arithmetic/

> 
> -- Jon
> 
> On 05/12/2015 02:29 AM, Stanislav Baiduzhyi wrote:
> > On Wednesday 06 May 2015 11:15:30 Stanislav Baiduzhyi wrote:
> >> On Tuesday 05 May 2015 23:36:56 Magnus Ihse Bursie wrote:
> >>> On 2015-05-04 14:56, Stanislav Baiduzhyi wrote:
> >>>> Hi All,
> >>>> 
> >>>> I'm getting multiple "arithmetic syntax error" when working with
> >>>> non-commited changes. I've made a small fix, could anyone please take a
> >>>> look, and incorporate those changes into upstream if you like the fix?
> >>>> 
> >>>> https://e5decb045a719fb58df46fd7e03c2f98cddc1ac6.googledrive.com/host/0
> >>>> B
> >>>> 5K
> >>>> p-cB1sXJrfk9NQTVHMTJTdWpYX3dWaExreWN0V0hQZ3d0eGIyZDltdHBCbmhYcXpzRFk/fi
> >>>> x
> >>>> -a
> >>>> rithmetic/
> >>> 
> >>> Hi Stanislav,
> >>> 
> >>> While the changes look reasonable, I'm curious why this hasn't surfaced
> >>> as a problem before. The missing $ just looks plain broken, but why is
> >>> the extra -n test needed?
> >>> 
> >>> What do you do to trigger the problem? What version of ksh are you
> >>> using?
> >> 
> >> Hi Magnus,
> >> 
> >> Thanx for your reply. I was wondering myself how is this possible. I'm
> >> using the tip from http://hg.openjdk.java.net/code-tools/webrev/ . I
> >> think it works fine without that -n check, error only goes to output and
> >> as in any shell the failing command means 'false'. So that check only
> >> affects the output.
> >> 
> >> Distribution is openSUSE 13.2.
> >> 
> >> Reproducing the issue like this:
> >> $ ksh --version
> >> 
> >>    version         sh (AT&T Research) 93v- 2014-06-25
> >> 
> >> $ hg clone http://hg.openjdk.java.net/code-tools/webrev/
> >> $ cd webrev
> >> # changing anything:
> >> $ echo 'echo "the quick brown fox"' >>webrev.ksh
> >> # launching webrev:
> >> $ ksh webrev.ksh -N -m -u 'Stanislav Baiduzhyi'
> >> 
> >>     SCM detected: mercurial
> >>   
> >>   No outgoing, perhaps you haven't commited.
> >>   
> >>        Workspace: /home/user/work/src/jdk-dev/showroom/webrev
> >>        Output to: /home/user/work/src/jdk-dev/showroom/webrev/webrev
> >>     
> >>     Output Files:
> >> webrev.ksh: line 2282: i: arithmetic syntax error
> >> # fixing the missing $ error:
> >> $ sed -i 's;\[\[ i -lt;\[\[ $i -lt;' webrev.ksh
> >> # trying once again:
> >> $ ksh webrev.ksh -N -m -u 'Stanislav Baiduzhyi'
> >> 
> >>     SCM detected: mercurial
> >>   
> >>   No outgoing, perhaps you haven't commited.
> >>   
> >>        Workspace: /home/user/work/src/jdk-dev/showroom/webrev
> >>        Output to: /home/user/work/src/jdk-dev/showroom/webrev/webrev
> >>     
> >>     Output Files:
> >>          webrev.ksh
> >>          
> >>                  webrev.ksh[2366]: build_old_new[1792]:
> >> build_old_new_mercurial[1744]: [: : arithmetic syntax error
> >> 
> >>   patch cdiffs udiffs sdiffs frames old new
> >>   
> >>       index.html: Done.
> >> 
> >> Output to: /home/user/work/src/jdk-dev/showroom/webrev/webrev
> >> the quick brown fox
> > 
> > Any news on this issue? Am I using the webrev in a way it was intended to
> > or am I encountering those issues because I'm doing something wrong?

-- 
Regards,
    Stas