RFR(XS): CODETOOLS-7902075: jtreg doesn't build if jh.jar doesn't contain signatures

[Jonathan Gibbons]

Volker,

I can push the fix for you, but it may already be redundant.

If you use JT Harness 5, then you don't need JavaHelp at all.
Just leave JAVAHELP_JAR unset.

I've been pushing changes to jtreg this week to make it easier
to build jtreg, and although I haven't yet flipped the switch on making
the default be to use JT Harness 5, I have verified that you can
build and run jtreg, using JT Harness 5, without JavaHelp and without
JCov.

-- Jon

On 12/01/2017 08:29 AM, Volker Simonis wrote:
> Hi,
>
> can I please have a sponsor for the following simple fix of the jtreg build:
>
> http://cr.openjdk.java.net/~simonis/webrevs/2017/CODETOOLS-7902075/
> https://bugs.openjdk.java.net/browse/CODETOOLS-7902075
>
> Change "7901920: jh.jar is signed with a weak algorithm and its
> certificate is expired" introduced a logic to remove outdated
> signatures from jh.jar.
>
> However, there's no default location for downloading jh.jar and
> probably most available versions (e.g. the one from Maven:
> http://central.maven.org/maven2/javax/help/javahelp/2.0.05/javahelp-2.0.05.jar)
> if not all of them don't contain signatures at all. This breaks the
> build because removing the signatures from the jar file with zip will
> fail with the following error:
>
> zip warning: name not matched: META-INF/*.SF
> zip warning: name not matched: META-INF/*.RSA
> zip warning: name not matched: META-INF/*.DSA
> zip error: Nothing to do!
> (/net/usr.work/openjdk/tools/jtreg/jtreg/build/images/jtreg/lib/jh.jar
>
> It would be great if the sponsor could also tag this fix with
> jtreg4.2-b11 after pushing it because the last tagged version (i.e.
> jtreg4.2-b10) doesn't build out of the box without JCov (which should
> be optional and which was fixed by "7902072: Add support for imported
> license files").
>
> Thank you and best regards,
> Volker