[PATCH] 6512707: "incompatible types" after (unrelated) annotation processing [SEC=UNCLASSIFIED]

[Peter Runge]

Thanks Jon.  I'll remember those points for the next time.

Peter

-----Original Message-----
From: Jonathan.Gibbons at Sun.COM [mailto:Jonathan.Gibbons at Sun.COM]
Sent: Thursday, 8 January 2009 7:36 AM
To: Peter Runge
Cc: compiler-dev at openjdk.java.net
Subject: Re: [PATCH] 6512707: "incompatible types" after (unrelated)
annotation processing [SEC=UNCLASSIFIED]

Nice patch; thanks.

Very minor quibbles, for the record:
-- all source files should end in a single newline
-- most test source files should have a copyright block; the only
exception is when the source file is used in a jtreg "golden file" test,
so that the line numbers in the source file are significant. In this
case, the test description should contain the magic string
/nodynamiccopyright/ This should be explained in the OpenJDK developer's
handbook.

I'll fix these issues in your patch.

-- Jon


Peter Runge wrote:
> Attached is the patch for the TreeScanner fix described previously.
> Test cases included.
>
> I only sent off the SCA yesterday via e-mail so it might be some time 
> before it is processed.
>
> Regards,
>
> Peter
>
> If you have received this email in error, please notify the sender
immediately and erase all copies of the email and any attachments to it.
The information contained in this email and any attachments may be
private, confidential and legally privileged or the subject of
copyright. If you are not the addressee it may be illegal to review,
disclose, use, forward, or distribute this email and/or its contents.
>  
> Unless otherwise specified, the information in the email and any
attachments is intended as a guide only and should not be relied upon as
legal or technical advice or regarded as a substitute for legal or
technical advice in individual cases. Opinions contained in this email
or any of its attachments do not necessarily reflect the opinions of
ACMA.
>   


If you have received this email in error, please notify the sender immediately and erase all copies of the email and any attachments to it. The information contained in this email and any attachments may be private, confidential and legally privileged or the subject of copyright. If you are not the addressee it may be illegal to review, disclose, use, forward, or distribute this email and/or its contents.
 
Unless otherwise specified, the information in the email and any attachments is intended as a guide only and should not be relied upon as legal or technical advice or regarded as a substitute for legal or technical advice in individual cases. Opinions contained in this email or any of its attachments do not necessarily reflect the opinions of ACMA.