Code review for 7086595: Error message bug: name of initializer is 'null'

[Dalibor Topic]

On 12/4/11 5:09 PM, Dmeetry Degrave wrote:
> 
> I see some uncertainties if fixes are pushed to previous releases without a review,
> 
> - every push to repo needs a reviewer. It's mandatory, isn't ?

Yes, but jdk7u has a shortcut, so to speak - since we share many, if not all, reviewers with jdk8,
and in general want changes to go into jdk8, you don't need to have a separate review of an identical
fix for jdk7u that has gone into jdk8 already.

> - fix could be fine from technical point of view, but not appropriate for porting to a particular release for some other reason.

Yeah, that's one of the things a forest maintainer in jdk7u needs to look out for when they approve fixes.

cheers,
dalibor topic
 
> thanks,
> dmeetry
> 
> On 12/04/2011 07:03 PM, Weijun Wang wrote:
>> If the fix is identical, no code review is necessary. You only need to write to jdk7u-dev@ for a backport approval.
>>
>> -Max
>>
>>
>>
>> On Dec 4, 2011, at 2:24 AM, Dmeetry Degrave<Dmitry.Degrave at oracle.com>  wrote:
>>
>>> Hi,
>>>
>>> I'm looking for a code review for 7086595. This is a port from jdk8 to 7u4 with identical fix.
>>>
>>> bug: http://bugs.sun.com/view_bug.do?bug_id=7086595
>>> webrev: http://cr.openjdk.java.net/~dmeetry/7086595/webrev.0/
>>> jdk8: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ed338593b0b6
>>>
>>> thanks,
>>> dmeetry


-- 
Oracle <http://www.oracle.com>
Dalibor Topic | Java F/OSS Ambassador
Phone: +494023646738 <tel:+494023646738> | Mobile: +491772664192 <tel:+491772664192>
Oracle Java Platform Group

ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Geschäftsführer: Jürgen Kunz

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment