Code review for 7086595: Error message bug: name of initializer is 'null'

[Dmeetry Degrave]

On 12/05/2011 11:08 PM, Dalibor Topic wrote:
> On 12/4/11 5:09 PM, Dmeetry Degrave wrote:
>>
>> I see some uncertainties if fixes are pushed to previous releases without a review,
>>
>> - every push to repo needs a reviewer. It's mandatory, isn't ?
>
> Yes, but jdk7u has a shortcut, so to speak - since we share many, if not all, reviewers with jdk8,
> and in general want changes to go into jdk8, you don't need to have a separate review of an identical
> fix for jdk7u that has gone into jdk8 already.

to be crystal clear here, whose openjdk name is supposed to be used in 
"Reviewed-by:" field ?

thanks,
dmeetry

>> - fix could be fine from technical point of view, but not appropriate for porting to a particular release for some other reason.
>
> Yeah, that's one of the things a forest maintainer in jdk7u needs to look out for when they approve fixes.
>
> cheers,
> dalibor topic
>
>> thanks,
>> dmeetry
>>
>> On 12/04/2011 07:03 PM, Weijun Wang wrote:
>>> If the fix is identical, no code review is necessary. You only need to write to jdk7u-dev@ for a backport approval.
>>>
>>> -Max
>>>
>>>
>>>
>>> On Dec 4, 2011, at 2:24 AM, Dmeetry Degrave<Dmitry.Degrave at oracle.com>   wrote:
>>>
>>>> Hi,
>>>>
>>>> I'm looking for a code review for 7086595. This is a port from jdk8 to 7u4 with identical fix.
>>>>
>>>> bug: http://bugs.sun.com/view_bug.do?bug_id=7086595
>>>> webrev: http://cr.openjdk.java.net/~dmeetry/7086595/webrev.0/
>>>> jdk8: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ed338593b0b6
>>>>
>>>> thanks,
>>>> dmeetry
>
>