request for review

A. Sundararajan sundararajan.athijegannathan at oracle.com
Wed Dec 18 03:18:36 PST 2013


Hi,

Looks good.

PS. I am not an official reviewer for javac

-Sundar

On Wednesday 18 December 2013 04:46 PM, Vicente-Arturo Romero-Zaldivar 
wrote:
> Hi Sundar,
>
> New webrev uploaded, after your comments. The diff is a change in 
> visibility for field "isInitialConstructor", set now to private.
>
> http://cr.openjdk.java.net/~vromero/8030218/webrev_02
>
> Thanks,
> Vicente
>
>
> On 18/12/13 10:42, Vicente-Arturo Romero-Zaldivar wrote:
>> Hello,
>>
>> Please review this patch for javac 9. A compile time error isn't 
>> shown when final static field is not assigned and the constructor 
>> throws an exception. This fix should sync javac with the spec in this 
>> aspect.
>>
>> The webrev is here:
>> http://cr.openjdk.java.net/~vromero/8030218/webrev_01
>>
>> The bug report is here:
>> https://bugs.openjdk.java.net/browse/JDK-8030218
>>
>> Please check this bug entry as a reference (original bug report):
>> https://bugs.openjdk.java.net/browse/JDK-8020216
>>
>> Thanks,
>> Vicente
>



More information about the compiler-dev mailing list