request for review
Joel Borggrén-Franck
joel.franck at oracle.com
Wed Dec 18 08:30:25 PST 2013
Hi Vicente,
Looks good.
cheers
/Joel
On 18 Dec 2013, at 12:16, Vicente-Arturo Romero-Zaldivar <vicente.romero at oracle.com> wrote:
> Hi Sundar,
>
> New webrev uploaded, after your comments. The diff is a change in visibility for field "isInitialConstructor", set now to private.
>
> http://cr.openjdk.java.net/~vromero/8030218/webrev_02
>
> Thanks,
> Vicente
>
>
> On 18/12/13 10:42, Vicente-Arturo Romero-Zaldivar wrote:
>> Hello,
>>
>> Please review this patch for javac 9. A compile time error isn't shown when final static field is not assigned and the constructor throws an exception. This fix should sync javac with the spec in this aspect.
>>
>> The webrev is here:
>> http://cr.openjdk.java.net/~vromero/8030218/webrev_01
>>
>> The bug report is here:
>> https://bugs.openjdk.java.net/browse/JDK-8030218
>>
>> Please check this bug entry as a reference (original bug report):
>> https://bugs.openjdk.java.net/browse/JDK-8020216
>>
>> Thanks,
>> Vicente
>
More information about the compiler-dev
mailing list