Request for Review JDK-8006948: Update javac for MethodParameters format change

Kumar Srinivasan kumar.x.srinivasan at oracle.com
Fri Jan 25 10:32:38 PST 2013


Eric,

> Hello,
>
> Please review this change, which updates javac and the classfile library
> to reflect changes in the class file format of MethodParameters attributes.
What was the reason to make this change ?
> The webrev is here:
> http://cr.openjdk.java.net/~emc/8006948/webrev.00/
>
> The latest version of the spec can be found here:
> http://cr.openjdk.java.net/~abuckley/8.misc
>
> The enhancement request is here:
> http://bugs.sun.com/view_bug.do?bug_id=8006948
>
>
> Note that this will break compatibility with existing versions.
> Furthermore, the companion changeset for hotspot will go into hsx, and
> will take some time to propagate to TL.  However, there are no tests
> enabled at this point that rely on the old binary format, so there
> should be no JPRT failures arising from this fix.
Not  true, this will break pack200. and there are  tests in place for this.
http://cr.openjdk.java.net/~ksrini/8005252/webrev.1/

also a spec change for JSR-200 is needed to accommodate this.
http://cr.openjdk.java.net/~ksrini/8005252/webrev.pubs.0/webrev/

Thanks
Kumar



Kumar

>
> Thanks,
> Eric




More information about the compiler-dev mailing list