Request for Review JDK-8006948: Update javac for MethodParameters format change

[Eric McCorkle]

On 01/25/13 13:32, Kumar Srinivasan wrote:
> Eric,
> 
>> Hello,
>>
>> Please review this change, which updates javac and the classfile library
>> to reflect changes in the class file format of MethodParameters
>> attributes.
> What was the reason to make this change ?

It was decided that the SYNTHESIZED flag would be 0x8000, not 0x10000 as
it was in a previous version of the spec.  Therefore, there is no reason
for the flags field to be u4.

It bears mention that the u4 causes alignment trap issues if not handled
carefully.

> Not  true, this will break pack200. and there are  tests in place for this.
> http://cr.openjdk.java.net/~ksrini/8005252/webrev.1/
> 

What would it take to update these tests accordingly?  I assume they are
in TL, and thus can be addressed with a follow-up?

> also a spec change for JSR-200 is needed to accommodate this.
> http://cr.openjdk.java.net/~ksrini/8005252/webrev.pubs.0/webrev/

Then whoever is in charge of that spec should take note of the changes to
http://cr.openjdk.java.net/~abuckley/8misc.pdf

Note: I am not in charge of the enhanced metadata spec.  Please consult
Alex regarding any issues.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eric_mccorkle.vcf
Type: text/x-vcard
Size: 314 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20130125/ec224892/eric_mccorkle.vcf