RFR: 8044131: Restructure sjavac client / server protocol code

[Fredrik Öhrström]

Looks very nice, but:
  did you drop the id supplied from the commandline? Its very useful for
debugging the openjdk build.
  The implementation classes IdleResetSJavac and friends should not be
public.

//Fredrik




2014-07-03 14:45 GMT+02:00 Andreas Lundblad <andreas.lundblad at oracle.com>:

> Hi compiler-dev,
>
> Feel free to review this sjavac patch which addresses JDK-8044131.
>
> Description:
> The patch changes the following:
>
> - replaces the manual (de)serialization with
> ObjectOutputStream/ObjectInputStream
>
> - unifies the interfaces of local ("background=false") compilation and
> remote ("background=true") compilation
>
> - factors out thread pooling, idleness detection and port file monitoring
> into their own classes for better modularity
>
> The new, more modular, structure allows for better unit testing of the
> functionality. (See for instance the tests IdleShutdown.java and
> PooledExecution.java.)
>
> As part of the refactoring, JDK-8048457 was also solved.
>
>
> Link to webrev:
> http://cr.openjdk.java.net/~alundblad/8044131/
>
> Links to bug report:
> https://bugs.openjdk.java.net/browse/JDK-8044131
> https://bugs.openjdk.java.net/browse/JDK-8048457
>
> -- Andreas
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140703/a9f72a27/attachment.html>