Review Request - 2 : JDK-8031670: remove unneeded -source option from javadoc tests

[Neil Toda]

Thanks Joe

Cleaner.  I'll do that.

-neil

On 3/1/2014 2:06 PM, Joe Darcy wrote:
> Hi Neil,
>
> Typically with negative tests, we do a golden file check on the 
> non-localized output to verify the right error is reported in the 
> right location. However, for testing the supported-ness of the source 
> value, that isn't really necessary.
>
> Instead of adding SourceOption2.java as a separate file, please 
> sightly restructure SourceOption to allow it to take a source option 
> as an argument.
>
> In other words, the jtreg tags could be like
>
>   29  * @run main/fail SourceOption 7
>   30  * @run main  SourceOption latest
>
> as long the main method translated from 7/latest to a source argument 
> for the string array that gets passed in.
>
> Look at javax.lang.model.SourceVersion to compute latest, or if you 
> want to keep things simpler, just support
>
>
>   29  * @run main/fail SourceOption 7
>   30  * @run main  SourceOption 9
>
> and pass the source argument down.
>
> Otherwise, the changes look fine to go back.
>
> Thanks,
>
> -Joe
>
> On 02/27/2014 08:13 AM, Neil Toda wrote:
>> This is a Review Request resubmission with reviewer-based changes.
>>
>> Original Description:
>>
>>     A small set of javadoc tests contain the -source parameter.  In
>>     most cases, the parameter is
>>     not required for the test.  In several cases, the -source
>>     parameter is being explicitly tested,
>>     but relies on a JDK version that will be removed from JDK9.
>>
>>     This changeset removes unnecessary -source specification when not
>>     needed, or changes the
>>     test/source-version requested to one that will work in JDK9
>>
>>
>> The revised changeset-webrev can be found here:
>>
>> http://cr.openjdk.java.net/~darcy/neiltoda/8031670.1/
>>
>>
>> Changes from first submittal:
>>
>>   * in ./test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java
>>     * correct spelling error : amy -> may
>>     * remove comment on test from jtreg tag block
>>   * to validate -source option operation
>>     * reinstate ./sourceOption test
>>     * in ./test/tools/javadoc/sourceOption/SourceOption.java
>>       * changed to a negative test to make sure javac lambda 
>> construct is not in 1.7
>>       * add information about updating test periodically
>>       * add a fixVersion bug [ set to 1.10 for current targeted feature ]
>>     * added ./test/tools/javadoc/sourceOption/p/LambdaConstructTest.java
>>       * valid for 1.8, but not for 1.7. "-source 1.7" is checked with 
>> this code.
>>     * added ./test/tools/javadoc/sourceOption2/SourceOption2.java
>>       * This test is a positive test to make sure that the lambda 
>> construct provided for ./sourceOption is valid for 8.
>>       * This test is actually examining 
>> ./sourceOption/p/LambdaConstructTest.java
>>
>> Thanks
>>
>> -neil
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140303/ccfca858/attachment.html