JDK 9 RFR for documenting JSR 269 readObject methods

Jonathan Gibbons jonathan.gibbons at oracle.com
Tue Mar 11 20:56:24 UTC 2014


Looks good to me.

-- Jon

On 03/07/2014 04:41 PM, Joe Darcy wrote:
> Hello,
>
> Please review the small patch below with adds some javadoc to the 
> readObject methods's of two JSR 269 exception types.
>
> Thanks,
>
> -Joe
>
> diff -r f675ddb8bd67 
> src/share/classes/javax/lang/model/type/MirroredTypeException.java
> --- 
> a/src/share/classes/javax/lang/model/type/MirroredTypeException.java 
> Fri Mar 07 13:30:23 2014 -0800
> +++ 
> b/src/share/classes/javax/lang/model/type/MirroredTypeException.java 
> Fri Mar 07 16:33:06 2014 -0800
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2005, 2012, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2005, 2014, Oracle and/or its affiliates. All rights 
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -70,6 +70,10 @@
>
>      /**
>       * Explicitly set all transient fields.
> +     * @param s the serial stream
> +     * @throws ClassNotFoundException for a missing class during
> +     * deserialization
> +     * @throws IOException for an IO problem during deserialization
>       */
>      private void readObject(ObjectInputStream s)
>          throws IOException, ClassNotFoundException {
> diff -r f675ddb8bd67 
> src/share/classes/javax/lang/model/type/MirroredTypesException.java
> --- 
> a/src/share/classes/javax/lang/model/type/MirroredTypesException.java 
> Fri Mar 07 13:30:23 2014 -0800
> +++ 
> b/src/share/classes/javax/lang/model/type/MirroredTypesException.java 
> Fri Mar 07 16:33:06 2014 -0800
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2005, 2012, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2005, 2014, Oracle and/or its affiliates. All rights 
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -85,6 +85,10 @@
>
>      /**
>       * Explicitly set all transient fields.
> +     * @param s the serial stream
> +     * @throws ClassNotFoundException for a missing class during
> +     * deserialization
> +     * @throws IOException for an IO problem during deserialization
>       */
>      private void readObject(ObjectInputStream s)
>          throws IOException, ClassNotFoundException {
>



More information about the compiler-dev mailing list