Public review of rearchitected front-end type annotations pipeline

[Eric McCorkle]

On 05/09/14 16:48, Werner Dietl wrote:
>>> two quick questions:
>>>
>>> - I don't see "Stress" anywhere in the patch. Is that test case included?
>>
>> Apologies, Stress.java got left out by accident.  That has been corrected.
> 
> Would it be better to write that test in the "referenceinfos" style?
> At the moment Stress just makes sure that all the different syntax
> elements work, which other tests in "newlocations" also do. It's not
> clear which of the examples in Stress previously worked and which
> didn't.
> The "referenceinfos" style of tests would also make sure that the
> generated bytecode contains the correct type annotations.
> 

The idea of Stress is to hit a whole bunch of edge cases.  While I'm not
opposed to expanding the newlocations tests (or preferably, writing a
combo-test), I would prefer to put Stress in as-is.

There is also the fact that it is a kind of regression test, as it
crashes 8-release javac.

>>> Is this a good time to adapt the Checker Framework to these changes or
>>> should I wait for patch 3?
>>
>> You should be fine.  Patch 3 does some very minor code moving, and a
>> whole lot of removal.
> 
> Is there a timeline for this patch? If it also comes within a few
> days, I'll rather wait for it.
> 

The dead code patch depends on this one (obviously), and unfortunately,
my only option for review until this patch goes in is to post a diff.

Ideally, this patch will be committed some time early next week, at
which point the dead code patch will immediately go up for review.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eric_mccorkle.vcf
Type: text/x-vcard
Size: 314 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140509/96d3c3f3/eric_mccorkle-0001.vcf>