RFR: 8056258: Analysis of public API does not take super classes into account

Fredrik Öhrström oehrstroem at gmail.com
Sun Sep 28 12:20:38 UTC 2014

Great looking code and I am +1 for committing this as it is!

Would you say that scanning the AST incurs a slight performance degradation
compared to the previous solution? Can we in the future merge public api
generation with AST dependency scanning?

On Fri, Sep 26, 2014 at 3:00 PM, Andreas Lundblad <
andreas.lundblad at oracle.com> wrote:

> Hi compiler-dev,
> Please review the fix for JDK-8056258 below.
> Description:
> The current approach for discovering dependencies in sjavac is to hook
> into Attr and Resolve (by registering subclasses of these classes in the
> context).
> This is a bit ad-hoc and does currently not support discovery of super
> classes.
> This patch refactors sjavac to instead scan for dependencies in the AST
> after attr is finished by using a TaskListener.
> Link to web review:
> http://cr.openjdk.java.net/~alundblad/8056258
> Link to bug reports:
> http://bugs.openjdk.java.net/browse/JDK-8056258
> -- Andreas Lundblad
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20140928/dc8ed61f/attachment.html>

More information about the compiler-dev mailing list