RFR: 8056258: Analysis of public API does not take super classes into account

Andreas Lundblad andreas.lundblad at oracle.com
Mon Sep 29 07:26:34 UTC 2014


On Sun, Sep 28, 2014 at 02:20:38PM +0200, Fredrik Öhrström wrote:
> Great looking code and I am +1 for committing this as it is!
> 
> Would you say that scanning the AST incurs a slight performance degradation
> compared to the previous solution?

I've not had time to do any benchmarking unfortunately. I consider this fix to be kind of urgent since the current code is slightly broken. My gut feeling is that it might be slightly slower. It's not anything I've noticed when compiling the JDK though.

> Can we in the future merge public api
> generation with AST dependency scanning?

My plan is to rewrite the dependency scanning in a similar way, but I consider the dependency scanning and public api scanning to be independent and would therefor like to keep the logic separated in the code.

-- Andreas


More information about the compiler-dev mailing list