RFR: 8215366: Code quality improvements in com.sun.tools.javac.code.TypeAnnotations

B. Blaser bsrbnd at gmail.com
Mon Dec 17 14:42:42 UTC 2018


Perfect, I'll re-base the fix for JDK-8208470 once Liam has pushed this.
Bernard

On Mon, 17 Dec 2018 at 15:15, Maurizio Cimadamore
<maurizio.cimadamore at oracle.com> wrote:
>
> Looks good
>
> Thanks
> Maurizio
>
> On 13/12/2018 20:29, B. Blaser wrote:
> > You'll still need a Reviewer approval but these changes seem good to
> > me, as discussed earlier, excepted that you'd need to update the
> > copyright year.
> >
> > Thanks,
> > Bernard
> >
> > On Thu, 13 Dec 2018 at 19:37, Liam Miller-Cushon <cushon at google.com> wrote:
> >> Hi,
> >>
> >> Please consider this small cleanup to TypeAnnotations, which was based on discussion in the review thread for JDK-8208470. The change removes an unused helper method, and makes the handling of type annotation position information more consistent.
> >>
> >> bug: https://bugs.openjdk.java.net/browse/JDK-8215366
> >> webrev: http://cr.openjdk.java.net/~cushon/8215366/webrev.00/


More information about the compiler-dev mailing list