RFR: 8215366: Code quality improvements in com.sun.tools.javac.code.TypeAnnotations

[Liam Miller-Cushon]

Pushed as: http://hg.openjdk.java.net/jdk/jdk/rev/d5a2a29ca589

Thanks for the reviews!

On Mon, Dec 17, 2018 at 8:11 AM Werner Dietl <wdietl at gmail.com> wrote:

> Thanks for these cleanups, Liam!
> cu, WMD.
> On Mon, Dec 17, 2018 at 9:43 AM B. Blaser <bsrbnd at gmail.com> wrote:
> >
> > Perfect, I'll re-base the fix for JDK-8208470 once Liam has pushed this.
> > Bernard
> >
> > On Mon, 17 Dec 2018 at 15:15, Maurizio Cimadamore
> > <maurizio.cimadamore at oracle.com> wrote:
> > >
> > > Looks good
> > >
> > > Thanks
> > > Maurizio
> > >
> > > On 13/12/2018 20:29, B. Blaser wrote:
> > > > You'll still need a Reviewer approval but these changes seem good to
> > > > me, as discussed earlier, excepted that you'd need to update the
> > > > copyright year.
> > > >
> > > > Thanks,
> > > > Bernard
> > > >
> > > > On Thu, 13 Dec 2018 at 19:37, Liam Miller-Cushon <cushon at google.com>
> wrote:
> > > >> Hi,
> > > >>
> > > >> Please consider this small cleanup to TypeAnnotations, which was
> based on discussion in the review thread for JDK-8208470. The change
> removes an unused helper method, and makes the handling of type annotation
> position information more consistent.
> > > >>
> > > >> bug: https://bugs.openjdk.java.net/browse/JDK-8215366
> > > >> webrev: http://cr.openjdk.java.net/~cushon/8215366/webrev.00/
>
>
>
> --
> http://www.google.com/profiles/wdietl
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20181217/18f55e9f/attachment.html>