[langtools] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control
B. Blaser
bsrbnd at gmail.com
Thu Jun 7 16:36:23 UTC 2018
Hi David,
On 7 June 2018 at 12:02, David Holmes <david.holmes at oracle.com> wrote:
> Hi compiler-team,
>
> Was just getting ready to push this when I discovered a newly added test
> doesn't pass under nestmates:
>
> tools/javac/classfiles/attributes/Synthetic/AccessToPrivateInnerClassConstructorsTest.java
>
> webrev:
> http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.langtools.v5-incr/
>
> Fix was to reduce expected number of synthetic methods from 2 to 0, and
> expected number of synthetic classes from 1 to 0. This is similar to a
> previous change:
>
> http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.langtools.v1/test/langtools/tools/javac/classfiles/attributes/Synthetic/AccessToPrivateInnerClassMembersTest.java.cdiff.html
>
> Thanks,
> David
Looks good to me too.
I recently added this test while correcting an ancient bug which will
be implicitly solved by JEP 181 if target >= 11.
Cheers,
Bernard
More information about the compiler-dev
mailing list